Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about consistent tagging of toolkit code and test artifacts #140

Open
joergboe opened this issue Feb 5, 2019 · 1 comment
Open

Comments

@joergboe
Copy link
Member

joergboe commented Feb 5, 2019

Toolkits contain besides of the toolkit code other components which are:

  • samples
  • checked in documentation artifacts (this is not the generated spl-doc or java-doc etc)
  • test components
    When a toolkit is released, a tag is applied and the toolkit tests are initiated. But very often it turns out that the toolkit code is fine, but there are changes in the test components required.
    Thre are several ways to handle this:
  1. Remove the old tag and apply the label on the corrected checkin (bad practice, confusing and may break remote workspaces)
  2. Create a maintenance branch from the original label, implement the required changes, merge them into the main development branch and add a new label in the form vx.y.z_update1. Where the original label vx.y.z and the update contain the same toolkit code
  3. Separate the test folder from the rest of the toolkit code and put it into a separate repository
@ddebrunner
Copy link
Member

Not sure what the problem is exactly. Shouldn't the tests be run and passing before a release is made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants