Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] For information only: AppData use of @lru_cache decorator causes Error with Python3.7 #12

Closed
jeromemassot opened this issue Oct 5, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jeromemassot
Copy link

Summary

AppData module uses @lru_cache decorator without ( ) which apparently is not compatible with Python < 3.8 and this causes an Error when importing config.py which uses AppData.

To Reproduce
import zhot

Expected behavior
It should be imported without error.

Fix
It may be interesting to precise that Python version >= 3.8 is needed until AppData fixes the problem.

Remark
I am not a CS so my analysis of this problem could be totally wrong. If so, I would be thankful for anyone giving me a by-pass when working with Python 3.7

Thanks

Best regards

Jerome

@jeromemassot jeromemassot added the bug Something isn't working label Oct 5, 2022
@GabrielePicco
Copy link
Contributor

Thanks @jeromemassot for noticing, the bug should be resolved in #5. We got rid of AppData lib and just rely on pathlib. Will verify on python 3.6 and 3.7 before closing this issue.

@GabrielePicco GabrielePicco self-assigned this Oct 6, 2022
@jeromemassot
Copy link
Author

Thanks @GabrielePicco Gabriele for the comment.

@GabrielePicco
Copy link
Contributor

Problem was solved with #5 and merged in master, it will be included in the next release. Thanks again for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants