Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spyre test instructions fix #69

Merged
merged 2 commits into from
Jan 23, 2025
Merged

spyre test instructions fix #69

merged 2 commits into from
Jan 23, 2025

Conversation

yannicks1
Copy link
Contributor

@yannicks1 yannicks1 commented Jan 23, 2025

Small typo fix referring to wrong test script...

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@tdoublep
Copy link
Member

@yannicks1 IBM open-source repos require that all commits are "Signed". This can be done with adding the -s flag when doing git commit. If you want to sign existing commits, you can follow the instructions here:
https://github.com/IBM/vllm/pull/69/checks?check_run_id=36045485226

Copy link
Contributor

@jvlunteren jvlunteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
@yannicks1
Copy link
Contributor Author

@yannicks1 IBM open-source repos require that all commits are "Signed". This can be done with adding the -s flag when doing git commit. If you want to sign existing commits, you can follow the instructions here: https://github.com/IBM/vllm/pull/69/checks?check_run_id=36045485226

thanks for noticing, is fixed now.

@tdoublep tdoublep merged commit bf931dd into main Jan 23, 2025
10 checks passed
@tdoublep tdoublep deleted the ysc-test-commands branch January 23, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants