New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore fmt package when doing errcheck #1109

Merged

bai merged 1 commit into IBM:master from bai:errcheck-ignore-fmt

May 30, 2018

Contributor

bai commented May 30, 2018

This errcheck PR removed fmt.Fprintf from default exclude list and that makes CI sad, e.g. https://travis-ci.org/Shopify/sarama/jobs/385690067.

This PR brings back old behavior of errcheck.


          Ignore fmt package when doing errcheck

28ad786

bai requested a review from eapache

May 30, 2018 14:22

eapache approved these changes

View reviewed changes

bai merged commit 842ac3f into IBM:master

bai deleted the errcheck-ignore-fmt branch

May 30, 2018 15:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet