Skip to content

Commit 67937e4

Browse files
authoredMar 7, 2023
fix(Global Search): remove is_hidden param from search operation (#239)
Signed-off-by: francescadecicco <francescadecicco@it.ibm.com>
1 parent df61d02 commit 67937e4

File tree

2 files changed

+1
-33
lines changed

2 files changed

+1
-33
lines changed
 

‎globalsearchv2/global_search_v2.go

+1-23
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
/*
18-
* IBM OpenAPI SDK Code Generator Version: 3.63.0-5dae26c1-20230111-193039
18+
* IBM OpenAPI SDK Code Generator Version: 3.67.0-df2073a1-20230222-221157
1919
*/
2020

2121
// Package globalsearchv2 : Operations and models for the GlobalSearchV2 service
@@ -247,9 +247,6 @@ func (globalSearch *GlobalSearchV2) SearchWithContext(ctx context.Context, searc
247247
if searchOptions.CanTag != nil {
248248
builder.AddQuery("can_tag", fmt.Sprint(*searchOptions.CanTag))
249249
}
250-
if searchOptions.IsHidden != nil {
251-
builder.AddQuery("is_hidden", fmt.Sprint(*searchOptions.IsHidden))
252-
}
253250

254251
body := make(map[string]interface{})
255252
if searchOptions.Query != nil {
@@ -521,10 +518,6 @@ type SearchOptions struct {
521518
// only resources that user has permissions for tagging are returned (_for administrators only_).
522519
CanTag *string `json:"can_tag,omitempty"`
523520

524-
// Determines if the result set must return only the visible resources or not. If false (default), only visible
525-
// resources are returned; if true, only hidden resources are returned; if any, all resources are returned.
526-
IsHidden *string `json:"is_hidden,omitempty"`
527-
528521
// Allows users to set headers on API requests
529522
Headers map[string]string
530523
}
@@ -575,15 +568,6 @@ const (
575568
SearchOptionsCanTagTrueConst = "true"
576569
)
577570

578-
// Constants associated with the SearchOptions.IsHidden property.
579-
// Determines if the result set must return only the visible resources or not. If false (default), only visible
580-
// resources are returned; if true, only hidden resources are returned; if any, all resources are returned.
581-
const (
582-
SearchOptionsIsHiddenAnyConst = "any"
583-
SearchOptionsIsHiddenFalseConst = "false"
584-
SearchOptionsIsHiddenTrueConst = "true"
585-
)
586-
587571
// NewSearchOptions : Instantiate SearchOptions
588572
func (*GlobalSearchV2) NewSearchOptions() *SearchOptions {
589573
return &SearchOptions{}
@@ -673,12 +657,6 @@ func (_options *SearchOptions) SetCanTag(canTag string) *SearchOptions {
673657
return _options
674658
}
675659

676-
// SetIsHidden : Allow user to set IsHidden
677-
func (_options *SearchOptions) SetIsHidden(isHidden string) *SearchOptions {
678-
_options.IsHidden = core.StringPtr(isHidden)
679-
return _options
680-
}
681-
682660
// SetHeaders : Allow user to set Headers
683661
func (options *SearchOptions) SetHeaders(param map[string]string) *SearchOptions {
684662
options.Headers = param

‎globalsearchv2/global_search_v2_test.go

-10
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@ var _ = Describe(`GlobalSearchV2`, func() {
184184
Expect(req.URL.Query()["is_public"]).To(Equal([]string{"false"}))
185185
Expect(req.URL.Query()["impersonate_user"]).To(Equal([]string{"testString"}))
186186
Expect(req.URL.Query()["can_tag"]).To(Equal([]string{"false"}))
187-
Expect(req.URL.Query()["is_hidden"]).To(Equal([]string{"false"}))
188187
res.Header().Set("Content-type", "application/json")
189188
res.WriteHeader(200)
190189
fmt.Fprint(res, `} this is not valid json {`)
@@ -214,7 +213,6 @@ var _ = Describe(`GlobalSearchV2`, func() {
214213
searchOptionsModel.IsPublic = core.StringPtr("false")
215214
searchOptionsModel.ImpersonateUser = core.StringPtr("testString")
216215
searchOptionsModel.CanTag = core.StringPtr("false")
217-
searchOptionsModel.IsHidden = core.StringPtr("false")
218216
searchOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
219217
// Expect response parsing to fail since we are receiving a text/plain response
220218
result, response, operationErr := globalSearchService.Search(searchOptionsModel)
@@ -272,7 +270,6 @@ var _ = Describe(`GlobalSearchV2`, func() {
272270
Expect(req.URL.Query()["is_public"]).To(Equal([]string{"false"}))
273271
Expect(req.URL.Query()["impersonate_user"]).To(Equal([]string{"testString"}))
274272
Expect(req.URL.Query()["can_tag"]).To(Equal([]string{"false"}))
275-
Expect(req.URL.Query()["is_hidden"]).To(Equal([]string{"false"}))
276273
// Sleep a short time to support a timeout test
277274
time.Sleep(100 * time.Millisecond)
278275

@@ -307,7 +304,6 @@ var _ = Describe(`GlobalSearchV2`, func() {
307304
searchOptionsModel.IsPublic = core.StringPtr("false")
308305
searchOptionsModel.ImpersonateUser = core.StringPtr("testString")
309306
searchOptionsModel.CanTag = core.StringPtr("false")
310-
searchOptionsModel.IsHidden = core.StringPtr("false")
311307
searchOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
312308

313309
// Invoke operation with a Context to test a timeout error
@@ -371,7 +367,6 @@ var _ = Describe(`GlobalSearchV2`, func() {
371367
Expect(req.URL.Query()["is_public"]).To(Equal([]string{"false"}))
372368
Expect(req.URL.Query()["impersonate_user"]).To(Equal([]string{"testString"}))
373369
Expect(req.URL.Query()["can_tag"]).To(Equal([]string{"false"}))
374-
Expect(req.URL.Query()["is_hidden"]).To(Equal([]string{"false"}))
375370
// Set mock response
376371
res.Header().Set("Content-type", "application/json")
377372
res.WriteHeader(200)
@@ -408,7 +403,6 @@ var _ = Describe(`GlobalSearchV2`, func() {
408403
searchOptionsModel.IsPublic = core.StringPtr("false")
409404
searchOptionsModel.ImpersonateUser = core.StringPtr("testString")
410405
searchOptionsModel.CanTag = core.StringPtr("false")
411-
searchOptionsModel.IsHidden = core.StringPtr("false")
412406
searchOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
413407

414408
// Invoke operation with valid options model (positive test)
@@ -442,7 +436,6 @@ var _ = Describe(`GlobalSearchV2`, func() {
442436
searchOptionsModel.IsPublic = core.StringPtr("false")
443437
searchOptionsModel.ImpersonateUser = core.StringPtr("testString")
444438
searchOptionsModel.CanTag = core.StringPtr("false")
445-
searchOptionsModel.IsHidden = core.StringPtr("false")
446439
searchOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
447440
// Invoke operation with empty URL (negative test)
448441
err := globalSearchService.SetServiceURL("")
@@ -490,7 +483,6 @@ var _ = Describe(`GlobalSearchV2`, func() {
490483
searchOptionsModel.IsPublic = core.StringPtr("false")
491484
searchOptionsModel.ImpersonateUser = core.StringPtr("testString")
492485
searchOptionsModel.CanTag = core.StringPtr("false")
493-
searchOptionsModel.IsHidden = core.StringPtr("false")
494486
searchOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
495487

496488
// Invoke operation
@@ -736,7 +728,6 @@ var _ = Describe(`GlobalSearchV2`, func() {
736728
searchOptionsModel.SetIsPublic("false")
737729
searchOptionsModel.SetImpersonateUser("testString")
738730
searchOptionsModel.SetCanTag("false")
739-
searchOptionsModel.SetIsHidden("false")
740731
searchOptionsModel.SetHeaders(map[string]string{"foo": "bar"})
741732
Expect(searchOptionsModel).ToNot(BeNil())
742733
Expect(searchOptionsModel.Query).To(Equal(core.StringPtr("testString")))
@@ -753,7 +744,6 @@ var _ = Describe(`GlobalSearchV2`, func() {
753744
Expect(searchOptionsModel.IsPublic).To(Equal(core.StringPtr("false")))
754745
Expect(searchOptionsModel.ImpersonateUser).To(Equal(core.StringPtr("testString")))
755746
Expect(searchOptionsModel.CanTag).To(Equal(core.StringPtr("false")))
756-
Expect(searchOptionsModel.IsHidden).To(Equal(core.StringPtr("false")))
757747
Expect(searchOptionsModel.Headers).To(Equal(map[string]string{"foo": "bar"}))
758748
})
759749
})

0 commit comments

Comments
 (0)
Please sign in to comment.