Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector moves and renames #96

Closed
ricellis opened this issue Sep 16, 2022 · 1 comment · Fixed by #115
Closed

Connector moves and renames #96

ricellis opened this issue Sep 16, 2022 · 1 comment · Fixed by #115
Assignees
Milestone

Comments

@ricellis
Copy link
Member

ricellis commented Sep 16, 2022

Renames to allow for other endpoints in future (we'll get the cloudant part from the package name):

  • CloudantSourceConnector -> ChangesSourceConnector
  • CloudantSinkConnector -> ChangesSinkConnector

Put the "public" content in these packages
com.ibm.cloud.cloudant.kafka.connect.connectors (for the *SourceConnector and *SinkConnector classes)
com.ibm.cloud.cloudant.kafka.connect.transforms (for the transforms)
com.ibm.cloud.cloudant.kafka.connect.transforms.predicates (for the predicates)

Put the other content in a sensible set of sub-packages in
com.ibm.cloud.cloudant.kafka.connect.internal

@ricellis ricellis mentioned this issue Sep 16, 2022
8 tasks
@ricellis ricellis added this to the 0.200.0 milestone Sep 20, 2022
@mojito317 mojito317 self-assigned this Sep 26, 2022
@mojito317
Copy link
Contributor

As we discussed offline earlier: CloudantSinkConnector should not be renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants