This repository has been archived by the owner on Jul 12, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose adding a
$highlight
token per this comment here: carbon-design-system/carbon#1710 (comment)cc @IBM/carbon-designers
Currently
Datepicker
highlight is set directly with a color variable instead of a token. Unfortunately this color variable won't work for g90 and g100 themes.So as it stands, the only way to fix this issue with the current
@carbon/themes
setup is to add a new token. This$highlight
token will allowDatePicker
to be updated in such a way that makes it a11y compliant for g90 and g100 themes.Changelog
New
$highlight
tokenChanged
$highlight
for each existing theme (blue20 for light themes, blue90 for dark ui themes like g90 and g100)