Skip to content
This repository has been archived by the owner on Jul 12, 2019. It is now read-only.

feat(themes): add highlight token #319

Merged
merged 1 commit into from
Feb 5, 2019
Merged

feat(themes): add highlight token #319

merged 1 commit into from
Feb 5, 2019

Conversation

jendowns
Copy link
Contributor

@jendowns jendowns commented Feb 4, 2019

I propose adding a $highlight token per this comment here: carbon-design-system/carbon#1710 (comment)

cc @IBM/carbon-designers

Currently Datepicker highlight is set directly with a color variable instead of a token. Unfortunately this color variable won't work for g90 and g100 themes.

So as it stands, the only way to fix this issue with the current @carbon/themes setup is to add a new token. This $highlight token will allow DatePicker to be updated in such a way that makes it a11y compliant for g90 and g100 themes.

Changelog

New

  • add $highlight token

Changed

  • set $highlight for each existing theme (blue20 for light themes, blue90 for dark ui themes like g90 and g100)

@netlify
Copy link

netlify bot commented Feb 4, 2019

Deploy preview for carbon-elements ready!

Built with commit 8814c04

https://deploy-preview-319--carbon-elements.netlify.com

@aagonzales
Copy link
Member

This is ok by me!

@joshblack joshblack merged commit 3fda190 into carbon-design-system:master Feb 5, 2019
@jendowns jendowns deleted the theme_highlight branch February 7, 2019 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants