Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more secure JWTs for password reset and email verification #687

Closed
tibetsprague opened this issue Oct 6, 2021 · 2 comments
Closed
Assignees

Comments

@tibetsprague
Copy link
Contributor

Add auth by JWT for password reset and email verification:

  • tokens expire after a few hours
@tibetsprague
Copy link
Contributor Author

but then we need a session created for the user too, how does that work?

@lorenjohnson
Copy link
Member

lorenjohnson commented Oct 21, 2021

Just a note about Mobile, cookies, and JWT--wanted to put this somewhere and this ticket seems as good as any for the moment:

While our cookie-based setup in mobile basically just works now, it's problematic by definition. I think some of the issues with cookies in the native environment are the root cause of some remaining socket connection inconsistency issues which I'm currently trying to get to the bottom of.

I'm not any more certain than you about JWT being the final solution, but it would definitely be a solid basis for ironing things out on mobile.

Here is the gory details of the state of cookie based auth / sessions in React Native:

facebook/react-native#23185

Sorry that this is still somewhat nebulous and inconclusive. If we don't end-up on JWT auth right away things will still work ok on mobile, so just take this note as confirmation that there may be reasons--at least in mobile--to keep looking to full access with JWTs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants