Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check active actions when listing animations #210

Closed
keianhzo opened this issue Mar 23, 2023 · 0 comments · Fixed by #212
Closed

Check active actions when listing animations #210

keianhzo opened this issue Mar 23, 2023 · 0 comments · Fixed by #212
Assignees
Milestone

Comments

@keianhzo
Copy link
Contributor

Description
We are currently only listing the tracks from NLA tracks for the object but the glTF exported docs state that:

An action will be exported if it is the active action on an object, or it is stashed to an NLA track (e.g. with the Stash or Push Down buttons in the Action Editor). Actions which are not associated with an object in one of these ways are not exported. If you have multiple actions you want to export, make sure they are stashed!

So in the case the user relies on just the active action, we are not showing it.

We should include both the active animation and the NLA track actions in the animations list.

To Reproduce
Steps to reproduce the behavior:

  • Add an animation action to an object
  • Add the Loop Animation component
  • Click on the + button to show the available animations.

Expected behavior
The current object active animation show be in the list.

Screenshots
Screenshot 2023-03-23 at 15 06 44

Additional context
https://discord.com/channels/498741086295031808/964183314674098276/1088114999014199346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant