From 409350668b5ebc9f3af18b767df47a9f076a9f6b Mon Sep 17 00:00:00 2001 From: devopsbo3 <69951731+devopsbo3@users.noreply.github.com> Date: Fri, 10 Nov 2023 12:27:53 -0600 Subject: [PATCH] Revert "cmd/evm: allow state dump regardless if test passes in statetest (#28484)" This reverts commit d362d8e34e1d158d53611e2740f1f4c7783ac895. --- cmd/evm/staterunner.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/cmd/evm/staterunner.go b/cmd/evm/staterunner.go index 618ddf2ede13..8a07fccdf886 100644 --- a/cmd/evm/staterunner.go +++ b/cmd/evm/staterunner.go @@ -108,14 +108,13 @@ func runStateTest(fname string, cfg vm.Config, jsonOut, dump bool) error { fmt.Fprintf(os.Stderr, "{\"stateRoot\": \"%#x\"}\n", root) } } - // Dump any state to aid debugging - if dump { - dump := state.RawDump(nil) - result.State = &dump - } if err != nil { - // Test failed, mark as so + // Test failed, mark as so and dump any state to aid debugging result.Pass, result.Error = false, err.Error() + if dump { + dump := state.RawDump(nil) + result.State = &dump + } } }) results = append(results, *result)