diff --git a/ydb/core/fq/libs/compute/ydb/control_plane/compute_database_control_plane_service.cpp b/ydb/core/fq/libs/compute/ydb/control_plane/compute_database_control_plane_service.cpp index 6d25d82b4062..2eadd15e1ea6 100644 --- a/ydb/core/fq/libs/compute/ydb/control_plane/compute_database_control_plane_service.cpp +++ b/ydb/core/fq/libs/compute/ydb/control_plane/compute_database_control_plane_service.cpp @@ -359,8 +359,9 @@ class TComputeDatabaseControlPlaneServiceActor : public NActors::TActorBootstrap const auto& mapping = cmsConfig.GetDatabaseMapping(); auto globalLoadConfig = Config.GetYdb().GetLoadControlConfig(); for (const auto& config: mapping.GetCommon()) { + auto databaseCounters = Counters->GetSubgroup("database", config.GetControlPlaneConnection().GetDatabase()); const auto clientActor = Register(CreateCmsGrpcClientActor(CreateGrpcClientSettings(config), CredentialsProviderFactory(GetYdbCredentialSettings(config.GetControlPlaneConnection()))->CreateProvider()).release()); - const auto cacheActor = Register(CreateComputeDatabasesCacheActor(clientActor, databasesCacheReloadPeriod, Counters).release()); + const auto cacheActor = Register(CreateComputeDatabasesCacheActor(clientActor, databasesCacheReloadPeriod, databaseCounters).release()); TActorId databaseMonitoringActor; const NConfig::TLoadControlConfig& loadConfig = config.GetLoadControlConfig().GetEnable() ? config.GetLoadControlConfig() @@ -374,7 +375,7 @@ class TComputeDatabaseControlPlaneServiceActor : public NActors::TActorBootstrap } else { clientActor = Register(CreateMonitoringGrpcClientActor(CreateGrpcClientSettings(config), credentialsProvider).release()); } - databaseMonitoringActor = Register(CreateDatabaseMonitoringActor(clientActor, loadConfig, Counters).release()); + databaseMonitoringActor = Register(CreateDatabaseMonitoringActor(clientActor, loadConfig, databaseCounters).release()); } Clients->CommonDatabaseClients.push_back({clientActor, config, cacheActor, databaseMonitoringActor}); } @@ -382,8 +383,9 @@ class TComputeDatabaseControlPlaneServiceActor : public NActors::TActorBootstrap Y_ABORT_UNLESS(Clients->CommonDatabaseClients); for (const auto& [scope, config]: mapping.GetScopeToComputeDatabase()) { + auto databaseCounters = Counters->GetSubgroup("database", config.GetControlPlaneConnection().GetDatabase()); const auto clientActor = Register(CreateCmsGrpcClientActor(CreateGrpcClientSettings(config), CredentialsProviderFactory(GetYdbCredentialSettings(config.GetControlPlaneConnection()))->CreateProvider()).release()); - const auto cacheActor = Register(CreateComputeDatabasesCacheActor(clientActor, databasesCacheReloadPeriod, Counters).release()); + const auto cacheActor = Register(CreateComputeDatabasesCacheActor(clientActor, databasesCacheReloadPeriod, databaseCounters).release()); TActorId databaseMonitoringActor; const NConfig::TLoadControlConfig& loadConfig = config.GetLoadControlConfig().GetEnable() ? config.GetLoadControlConfig() @@ -397,7 +399,7 @@ class TComputeDatabaseControlPlaneServiceActor : public NActors::TActorBootstrap } else { clientActor = Register(CreateMonitoringGrpcClientActor(CreateGrpcClientSettings(config), credentialsProvider).release()); } - databaseMonitoringActor = Register(CreateDatabaseMonitoringActor(clientActor, loadConfig, Counters).release()); + databaseMonitoringActor = Register(CreateDatabaseMonitoringActor(clientActor, loadConfig, databaseCounters).release()); } Clients->ScopeToDatabaseClient[scope] = {clientActor, config, cacheActor, databaseMonitoringActor}; } @@ -406,16 +408,18 @@ class TComputeDatabaseControlPlaneServiceActor : public NActors::TActorBootstrap void CreateControlPlaneClientActors(const NConfig::TYdbComputeControlPlane::TYdbcp& controlPlaneConfig, const TString& databasesCacheReloadPeriod) { const auto& mapping = controlPlaneConfig.GetDatabaseMapping(); for (const auto& config: mapping.GetCommon()) { + auto databaseCounters = Counters->GetSubgroup("database", config.GetControlPlaneConnection().GetDatabase()); const auto clientActor = Register(CreateYdbcpGrpcClientActor(CreateGrpcClientSettings(config), CredentialsProviderFactory(GetYdbCredentialSettings(config.GetControlPlaneConnection()))->CreateProvider()).release()); - const auto cacheActor = Register(CreateComputeDatabasesCacheActor(clientActor, databasesCacheReloadPeriod, Counters).release()); + const auto cacheActor = Register(CreateComputeDatabasesCacheActor(clientActor, databasesCacheReloadPeriod, databaseCounters).release()); Clients->CommonDatabaseClients.push_back({clientActor, config, cacheActor, {}}); } Y_ABORT_UNLESS(Clients->CommonDatabaseClients); for (const auto& [scope, config]: mapping.GetScopeToComputeDatabase()) { + auto databaseCounters = Counters->GetSubgroup("database", config.GetControlPlaneConnection().GetDatabase()); const auto clientActor = Register(CreateYdbcpGrpcClientActor(CreateGrpcClientSettings(config), CredentialsProviderFactory(GetYdbCredentialSettings(config.GetControlPlaneConnection()))->CreateProvider()).release()); - const auto cacheActor = Register(CreateComputeDatabasesCacheActor(clientActor, databasesCacheReloadPeriod, Counters).release()); + const auto cacheActor = Register(CreateComputeDatabasesCacheActor(clientActor, databasesCacheReloadPeriod, databaseCounters).release()); Clients->ScopeToDatabaseClient[scope] = {clientActor, config, cacheActor, {}}; } } diff --git a/ydb/core/fq/libs/compute/ydb/control_plane/monitoring_rest_client_actor.cpp b/ydb/core/fq/libs/compute/ydb/control_plane/monitoring_rest_client_actor.cpp index a8fb27b271fa..39c940104e8b 100644 --- a/ydb/core/fq/libs/compute/ydb/control_plane/monitoring_rest_client_actor.cpp +++ b/ydb/core/fq/libs/compute/ydb/control_plane/monitoring_rest_client_actor.cpp @@ -26,24 +26,6 @@ namespace NFq { using namespace NActors; -namespace { - -auto RetryPolicy = NYql::NDq::THttpSenderRetryPolicy::GetExponentialBackoffPolicy( - [](const NHttp::TEvHttpProxy::TEvHttpIncomingResponse* resp){ - if (!resp || !resp->Response) { - // Connection wasn't established. Should retry. - return ERetryErrorClass::ShortRetry; - } - - if (resp->Response->Status == "401") { - return ERetryErrorClass::NoRetry; - } - - return ERetryErrorClass::ShortRetry; - }); - -} - class TMonitoringRestServiceActor : public NActors::TActor { public: using TBase = NActors::TActor; @@ -76,7 +58,7 @@ class TMonitoringRestServiceActor : public NActors::TActorGetRawData()); httpRequest->Set("Authorization", CredentialsProvider->GetAuthInfo()); - auto httpSenderId = Register(NYql::NDq::CreateHttpSenderActor(SelfId(), HttpProxyId, RetryPolicy)); + auto httpSenderId = Register(NYql::NDq::CreateHttpSenderActor(SelfId(), HttpProxyId, NYql::NDq::THttpSenderRetryPolicy::GetNoRetryPolicy())); Send(httpSenderId, new NHttp::TEvHttpProxy::TEvHttpOutgoingRequest(httpRequest), 0, Cookie); Requests[Cookie++] = ev; }