Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elm 0.19 compatibility #1

Open
noelrappin opened this issue Sep 1, 2018 · 4 comments · May be fixed by #3
Open

Elm 0.19 compatibility #1

noelrappin opened this issue Sep 1, 2018 · 4 comments · May be fixed by #3

Comments

@noelrappin
Copy link

Having trouble using this package with Elm 0.19. Are there plans to upgrade? Would a PR be welcome?
@HolyMeekrob
Copy link
Owner

I'll upgrade the package when all dependencies upgrade. It looks like the elm test runner hasn't been upgraded yet.

@razzeee
Copy link

razzeee commented Sep 14, 2018

elm-test seems to be updated
https://github.com/elm-explorations/test

but elm-html-test not eeue56/elm-html-test#69

@klaftertief
Copy link

FIY, elm-html-test is now included in https://package.elm-lang.org/packages/elm-explorations/test/1.2.0/, and the CLI is out of beta.

@razzeee
Copy link

razzeee commented Nov 19, 2018

Started a branch here https://github.com/Razzeee/elm-font-awesome-5/tree/migrate-to-0.19 tests are still failing and the changes I did to fix shadowing variables are kinda meh.

@razzeee razzeee linked a pull request Nov 20, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to elm 0.19 razzeee/elm-font-awesome-5
4 participants
@noelrappin @klaftertief @HolyMeekrob @razzeee