Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package manager icons #5

Closed
Princesseuh opened this issue Feb 3, 2024 · 3 comments
Closed

Package manager icons #5

Princesseuh opened this issue Feb 3, 2024 · 3 comments

Comments

@Princesseuh
Copy link

Is your feature request related to a problem?

N/A

Describe the solution you'd like

It'd be cool if it'd show icons next to the package managers, like on the Biome website https://biomejs.dev/guides/getting-started/#installation

Describe alternatives you've considered

Well, not having icons, but it's not as nice, right

Additional Context

No response

@HiDeoo
Copy link
Owner

HiDeoo commented Feb 3, 2024

Oh, I love the idea, this looks super great!

Internally, this component relies on the Starlight built-in <Tabs> component and only builds on top of it to add syncing between the tabs. Unfortunately, the built-in component doesn't support this feature and only accepts a basic string as a tab label.

Replacing the built-in component with a custom one that would literally be 90% the same just to render an extra icon seems meh, so instead I just opened a new feature request in Starlight to add a new icon prop to the <TabItem> component that would accept the name of an icon from the Starlight icon set and render it next to the label.

If this is something of interest (I personally really like the idea), this would be a fairly easy addition, and I already have an unrelated opened PR that adds icons for npm, yarn, and pnpm. We could also add bun too and then this issue would be as good as solved.

@HiDeoo
Copy link
Owner

HiDeoo commented Mar 4, 2024

All the pre-requisites Starlight PRs have been merged and released and the feature is now available in the new v0.4.0 of the package.

image

Thanks again for the great feature request 🙌

@HiDeoo HiDeoo closed this as completed Mar 4, 2024
@Princesseuh
Copy link
Author

Really cool, awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants