Not working with Node 19.1

[kyrylkov]

For us croner stops working with Node 19.1 on Windows and Linux

[Hexagon]

Verified. Node 19.1 added to test matrix, and fails catastrophically.

Thanks for the report, will have a look asap.

[Hexagon]

@kyrylkov

Node 19.1 is broken by a bug in upstream V8, the problem is fixed in 19.0, but still exist in 19.1. Nothing to do about this except to wait for a new release of node,

nodejs/node#45171

19.1 - Broken

19.0 - OK

[kyrylkov]

@Hexagon Yep, that's what I suspected. There was nothing in 19.1 vs 19.0 that could have broken it except a bug. Upcoming 19.2 should address this taking into account that it was fixed in upstream V8.

Thanks!

[Hexagon]

Working my way around the Node 19.1 bug

[Hexagon]

Fixed in 5.3.5 👍

[kibertoad]

@Hexagon This was fixed in 19.2.0, would it make sense to remove workaround now?

[Hexagon]

@kibertoad Good point! The fix is just replacing narrow no break space with a normal space. Can keep it until we're sure that no one uses 19.1. If it isnt fixed in 19.1 too? Gotta check that. Always nice keeping the code as clean as possible 👍