Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound items comparison #822

Closed
Tracked by #3330
Jedzkie opened this issue Oct 26, 2015 · 12 comments
Closed
Tracked by #3330

Bound items comparison #822

Jedzkie opened this issue Oct 26, 2015 · 12 comments
Labels
component:client-interface Affecting the client interface (packets from/to the client) status:wontfix The issue can't/won't be fixed type:enhancement Issue describes an enhancement or feature that should be implemented

Comments

@Jedzkie
Copy link
Contributor

Jedzkie commented Oct 26, 2015

  1. In Aegis, When dropping a Bounded item, there's no message showing 'This item cannot be dropped.', in Herc, there's a message.
  2. in Aegis, When putting bound items in Storage, there's no message showing 'This item cannot be stored.', Instead it will show to you like you obtained the item, in Herc. there's a message.

Image and video hosting by TinyPic

  1. in Aegis, When trading bound items, there's no message showing 'This item cannot be traded.', in Herc, there's a message.
  2. In Aegis, When putting bound items in Cart, there's no message showing 'This item cannot be stored.' and 'You are over your weight limit.', Its like also in storage, It will show that you obtained the item again, in Herc, There's a message only.

Source: iRO Chaos

@MishimaHaruna
Copy link
Member

Should we really mimic Aegis in cases like these, where they do worse than us?

@kyeme
Copy link

kyeme commented Oct 26, 2015

Right, in Official, there is no warning message when the item is non-storagable/droppabe/tradable/mail. It will be much better if we have a settings wherein we can enable or disable the warning message.

@Jedzkie
Copy link
Contributor Author

Jedzkie commented Oct 26, 2015

@MishimaHaruna We are aiming to totally copy the configuration and the system of aegis. This is not a bug or something that breaks the mechanics of the game, this is the behavior of official servers.

@dastgirp
Copy link
Member

We do aim for totally copying aegis and their behavior only IF they are not having any flaw/bug.
In this case, I would agree with Haru..

@MishimaHaruna
Copy link
Member

Accurate emulation or being an Aegis clone (i.e. including flaws and bugs) has never been a goal of this project, otherwise we'd have designed things differently in many situations (i.e. we'd have designed the scripting system to load the unmodified scripts from Aegis). Instead, from my point of view, whenever it makes sense, we aim to improve the user (and developer) experience.

@xBeret
Copy link

xBeret commented Oct 26, 2015

Show the item was obtained is interesting because it shows the player that the item may not go to the warehouse and that are in your inventory, many aegis systems use it, even when the player take an inventory item is blocked the drop and try to play on the floor appears that the item was obtained

@MishimaHaruna
Copy link
Member

But the item was not obtained, you had it to begin with. The obtained message is misleading.

@Jedzkie
Copy link
Contributor Author

Jedzkie commented Oct 26, 2015

@MishimaHaruna Hmmm what if we add a configuration that allows the developer to use the behavior of aegis? Isn't it ok?

@xBeret
Copy link

xBeret commented Oct 26, 2015

Is not misleading. Test the server aegis to view when you add an item in storage he goes to storage more verification of aegis know you're over the limit then sends the item to the inventory, so it shows the item obtained

@dastgirp
Copy link
Member

Aegis sends obtain packet, but item was never deleted to begin with, also the user would not know whats happening...

Also waste of 1 packet...

@Nihadm89
Copy link
Contributor

I much prefer the message system. It seems like it would be effort put into something that isn't even an improvement, to me at least.

@dastgirp
Copy link
Member

dastgirp commented Nov 8, 2015

Maybe its time to close this, since our system is better.

@dastgirp dastgirp closed this as completed Nov 8, 2015
@MishimaHaruna MishimaHaruna added type:enhancement Issue describes an enhancement or feature that should be implemented status:wontfix The issue can't/won't be fixed component:client-interface Affecting the client interface (packets from/to the client) labels Mar 15, 2016
@Asheraf Asheraf mentioned this issue Mar 31, 2017
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:client-interface Affecting the client interface (packets from/to the client) status:wontfix The issue can't/won't be fixed type:enhancement Issue describes an enhancement or feature that should be implemented
Projects
None yet
Development

No branches or pull requests

6 participants