Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] hx-lua-simdjson breaks -D lua-vanilla #9900

Closed
shakesoda opened this issue Oct 2, 2020 · 2 comments · Fixed by #10915
Closed

[lua] hx-lua-simdjson breaks -D lua-vanilla #9900

shakesoda opened this issue Oct 2, 2020 · 2 comments · Fixed by #10915

Comments

@shakesoda
Copy link

Per my comment on #9885: when using -D lua-vanilla (binary/external deps are a no-go), the flag is not respected as it was previously, and I get failed requires.

There should be a fallback to the generic parser when this flag is in use. I've worked around the issue by copying the generic parser out of std for the time being.

@jdonaldson
Copy link
Member

Thanks for your patience. I do agree this is problematic and I need to support "vanilla" development more robustly. I need to think through the design choices in more detail, I'm not sure if the "vanilla" flag is a good design pattern.

@RealyUniqueName RealyUniqueName added this to the Backlog milestone Oct 20, 2020
@inklit
Copy link
Contributor

inklit commented Jan 2, 2023

any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants