-
-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restoring lua tests #10777
Comments
Looks like we'll have to fork haxe-deps and handle this ourselves. I'm not sure what "making a release" entails here exactly, are we blocked from something if Justin doesn't handle it? |
I think it has to be uploaded here: https://luarocks.org/modules/jdonaldson/haxe-deps |
FYI, I attempted to fork haxe-deps and update it with my fork in my PR #10916 but found that simply changing the protocol to https did not seem to work, and after fiddling with it for too long I decided to just remove this dependency and manually reference the dependencies for the unit tests. |
@inklit I think it's important to have (and use) this package, as it pins down all the lua dependencies required to run the lua target in a single location. Otherwise, we have to manually keep the unit tests and documentation in sync, which is error prone and bound to cause issues. So I think it's worth fixing this package and adding it to the documentation. Looks like we have to use We should transfer the haxe-deps repository to HaxeFoundation (or make a fork) and figure out how we can add a new author to the luarocks package. |
Seems like we forgot to fix the lua tests after "temporarily disabling them" in 8027d74
We discussed this on slack a long time ago, but we need to update: https://github.com/jdonaldson/haxe-deps
as the
git:
protocol is no longer supported (which is used in the source url). I think it can just be updated tohttps
.@jdonaldson I made a PR for this, would you be able to handle making a release? HaxeFoundation/haxe-deps#2
Also, it is worth considering adding
luasec
to the file, because it is now a potential dependency since: #10593. This haxe-deps project seems to be used to install all potential dependencies, even if they are not necessarily used in all haxe lua projects, so it makes sense to add it. Right now we have to install it manually for the tests:haxe/tests/runci/targets/Lua.hx
Lines 73 to 74 in 55f4b33
We should also probably mention haxe-deps in the manual, but that is an issue for that repository.
The text was updated successfully, but these errors were encountered: