Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Vector instead of Array #9

Closed
Simn opened this issue Apr 3, 2019 · 2 comments
Closed

Use Vector instead of Array #9

Simn opened this issue Apr 3, 2019 · 2 comments

Comments

@Simn
Copy link
Member

Simn commented Apr 3, 2019

E.g. here: https://github.com/HaxeFoundation/crypto/blob/master/src/haxe/crypto/Aes.hx#L10

Vector is significantly faster on some targets.

@flashultra
Copy link
Collaborator

I'm planing to do this. At the moment vector copy() method ( for JS target) use blit() not slice() which give worse performance ( related to HaxeFoundation/haxe#8040 (comment))

@flashultra
Copy link
Collaborator

Done. Get performance boost mostly fot Java , C# and Python.
Here are some test values for Java:

     New  vs Old
     BlowFish - 0.92s vs 2.89s
     Ripemd160 - 0.80s vs 1.01s
     TwoFish - 0.12s vs 0.22s
     TripleDes - 1.88s vs 3.48s
     Sha512 - 0.16s vs 0.21s
     Sha384 - 0.13s vs 0.22s
     Sha256 - 0.11 vs 0.19s
     Sha224 - 0.13s vs 0.20s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants