Fixes delayed sampling for sequential requests #845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cached_step_inputs
andcached_step_outputs
still contain elements saved from the last served (batch) request. This shouldn't be the case.cached_step_inputs/outputs
if the recently generatedoutput
is the final token generated for the current batch request. But couldn't find a cleaner way to check for this in the model runner._patch_prev_output
) for when the scheduler context has empty output_queue, which means no pending outputs to patch.Tests here: https://github.com/habana-internal/mlperf_inference/pull/158