Hdf5 1 12 #28
Merged
Hdf5 1 12 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github workflow files parser files bin scripts doc corrections
qkoziol
requested changes
Oct 7, 2020
| hid_t split_fapl_id = H5I_INVALID_HID; | ||
| herr_t ret = SUCCEED; | ||
| int ret_value = 0; | ||
| H5FD_splitter_vfd_config_t *vfd_config = NULL; |
|
|
||
| if (splitter_prepare_file_paths(&vfd_config, filename_rw) < 0) { | ||
| char * filename_rw = NULL; | ||
| H5FD_splitter_vfd_config_t *vfd_config = NULL; |
| hid_t file_id = H5I_INVALID_HID; | ||
| const char * filename_tmp = "splitter_tmp.h5"; | ||
| char * filename_rw = NULL; | ||
| H5FD_splitter_vfd_config_t *vfd_config = NULL; |
|
The vfd.c file is identical in 1.10 and develop. splitter test is not 1.8 vfd.c. |
Can you create the issue with any information you have as to where and how the vfd splitter test fails in 1.12? |
lrknox
approved these changes
Oct 7, 2020
qkoziol
approved these changes
Oct 8, 2020
hyoklee
referenced
this pull request
in hyoklee/hdf5
Feb 12, 2021
…/bounds_compat * commit '181c6110251d7a9e9cc23e14dfd8f52cdb14422b': Correct macro check
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vfd test comments out the splitter test temporarily until it can fixed with later commits.