Combo set of async and other changes #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…callbacks, instead of directly accessing the list structure
…rieving a copy of the error stack for a failed asynchronous operation
…ted object or file into an event set
…ers to H5ESwait, to make it more "aggregate".
(b) Remove verification of name parameter in async related routines for H55A and H5L modules
because it is checked in H5VL_setup* routine.
(c) Modify h5dump expected output due to the async changes.
(a) Add async APIs for H5O module as listed in jira issue ID-283.
routine. Updated 'optional op' operations.
…r it and H5atclose
…d-union pattern for VOL callback arguments, instead of using varargs. Convert several 'get' routines to return the length of an array in a parameter instead of combining it into the return value. Move several routines to be in less public namespace. Correct direct_chunk test to verify that parameters aren't modified on error.
…async-friendly'. Also other minor cleanups and bug-fixes.
…ow skipping H5Dget_space + H5Sselect_hyperslab for async operation
These have been removed. |
soumagne
reviewed
May 26, 2021
soumagne
approved these changes
May 26, 2021
| #define H5S_ALL 0 /* (hid_t) */ | ||
| #define H5S_BLOCK 1 /* (hid_t) */ | ||
| #define H5S_PLIST 2 /* (hid_t) */ | ||
|
|
There was a problem hiding this comment.
I feel like you should add what they mean instead of hid_t ?
There was a problem hiding this comment.
I was just extending the list (which is like that in develop).
There was a problem hiding this comment.
Are they documented somewhere? I have no idea what they are
There was a problem hiding this comment.
I think it would not hurt to add a one-line description of their effect / when to use them, it does not seem to be in H5Dpublic.h either.
There was a problem hiding this comment.
Yes, definitely a good thing to do: #688
derobins
approved these changes
May 30, 2021
mkitti
added a commit
to mkitti/hdf5
that referenced
this pull request
Aug 5, 2022
mkitti
added a commit
to mkitti/hdf5
that referenced
this pull request
Aug 8, 2022
1 task
derobins
added a commit
that referenced
this pull request
Aug 16, 2022
* Revert "Revert H5Dchunk_iter changes in hdf5_1_12_1 (#733)" This reverts commit 10abe9a. * Apply clang-format * Reincorporate spelling fix from #1166 * Incorporate H5Dchunk_iter changes from #161 * Backport to 1.12: Adds a quick for for some egregious chunk_info badness (#722) * Backport to 1.12: Converts testhdf5 macros to h5test macros in chunk_info.c (#1820) The two macro schemes were not designed to work together. Also quiets some MSVC warnings about comparing pointers and integers. * Backport to 1.12: H5Dchunk_iter now passes offsets in units of dataset elements, fix #1419 (#1969) * H5Dchunk_iter now passes chunk dimension scaled offsets, fix #1419 * Update docs for H5Dchunk_iter, H5Dget_chunk_info* Modified description for `H5Dchunk_iter`, `H5Dget_chunk_info`, and `H5Dget_chunk_info_by_coord` to the following * offset Logical position of the chunk’s first element in units of dataset elements * filter_mask Bitmask indicating the filters used when the chunk was written * size Chunk size in bytes, 0 if the chunk does not exist * Sync H5Dchunk_iter documentation with develop * Remove H5VL_DATASET_WAIT references from 1.12 * Backport to 1.12 #161, #1474, review comments Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for all code to merge to develop, includes async, dynamic optional VOL operation registration, and H5S_BLOCK code.