Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential "use before initialization" bug #3969

Closed
radistmorse opened this issue Jan 29, 2024 · 0 comments · Fixed by #4087
Closed

Potential "use before initialization" bug #3969

radistmorse opened this issue Jan 29, 2024 · 0 comments · Fixed by #4087
Assignees
@derobins @glennsong09
Labels
Component - C Library Core C library issues (usually in the src directory) Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Bug / Bugfix Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub
Milestone
1.14.4

Comments

@radistmorse
Copy link

Describe the bug
I ran the valgrind analyser and it showed a "use before initialization" here https://github.com/HDFGroup/hdf5/blob/develop/src/H5Dchunk.c#L3290

The field fsel_type was marked as uninitialized by valgrind. The field was created here https://github.com/HDFGroup/hdf5/blob/develop/src/H5Dchunk.c#L1047, after I initialized the field manually the warning disappeared.

Tested on 1.14.3
@jreadey jreadey added Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - C Library Core C library issues (usually in the src directory) Type - Bug / Bugfix Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub labels Jan 30, 2024
@derobins derobins added this to the 1.14.4 milestone Jan 30, 2024
@derobins derobins self-assigned this Feb 16, 2024
@glennsong09 glennsong09 mentioned this issue Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derobins derobins

@glennsong09 glennsong09

Labels
Component - C Library Core C library issues (usually in the src directory) Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Bug / Bugfix Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub
Projects
None yet
Milestone
1.14.4
Development

Successfully merging a pull request may close this issue.

Initialize selection type in both if/else sections glennsong09/hdf5
4 participants
@derobins @radistmorse @jreadey @glennsong09