Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Spacing Hover On Right Click Dialog #13

Closed
RebeccaDeField opened this issue Jan 16, 2016 · 10 comments
Closed

Change Spacing Hover On Right Click Dialog #13

RebeccaDeField opened this issue Jan 16, 2016 · 10 comments

Comments

@RebeccaDeField
Copy link
Collaborator

Digitizer and I think it would be nice to change the way that the right click dialog box looks. Right now when you hover over an item, the hover color only extends to the end of the elements. I would like it to expand to the edges, but was having some trouble getting it to work. Some assistance would be much appriciated!

1
How it looks

2
How I want it to look

@Umcaruje
Copy link

Umcaruje commented Feb 4, 2016

Change line: https://github.com/LMMS/lmms/blob/master/data/themes/default/style.css#L79

To margin: 3px 0px 3px 0px;

That'll achieve the look you are looking for.

@RebeccaDeField
Copy link
Collaborator Author

Thanks for the help. When I used the code you provided on the line that you specified, the elments became flush to the left.

@RebeccaDeField RebeccaDeField reopened this Feb 6, 2016
@Umcaruje
Copy link

Umcaruje commented Feb 6, 2016

could you commit so I see your style.css?

@RebeccaDeField
Copy link
Collaborator Author

I'll be able to make a commit soon so that you can see the style.css file, but please note that I need to rebase my fork soon to pull in all of the recent changes made on the master branch.

There are still some things in progress and there will be some updates that are missing at the moment.

@RebeccaDeField
Copy link
Collaborator Author

@Umcaruje Just committed the style.css file. You should be able to see what I am currently working with.

@RebeccaDeField
Copy link
Collaborator Author

@Umcaruje just wanted to clarify few things:

  1. This might be a good update for the default theme as well.
  2. This is a low priority compared to other tasks, so no pressure.

@Umcaruje
Copy link

@Umcaruje just wanted to clarify few things:

Sure, but this really can be solved by adding some padding, I just haven't had the time to look at it. I'll issue a PR to add this to the default theme when I get around to it.

@Umcaruje
Copy link

@RebeccaDeField LMMS#2567 here you go. It was just a matter of adjusting the padding of the QMenu::item

@RebeccaDeField
Copy link
Collaborator Author

Again, thank you! 👍

I have noticed that you have been very active lately, completing many tasks that other people need help with. It is very appreciated.

@Umcaruje
Copy link

I have noticed that you have been very active lately, completing many tasks that other people need help with. It is very appreciated.

Glad I could help 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants