Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should i change model_name "glli/ART_GuideModel"? #6

Closed
reverseinread opened this issue Oct 22, 2024 · 1 comment
Closed

Should i change model_name "glli/ART_GuideModel"? #6

reverseinread opened this issue Oct 22, 2024 · 1 comment

Comments

@reverseinread
Copy link

i find it's always error when i use glli/ART_GuideModel as llava_lora_path in "def build_llava".
then i find "model_name=get_model_name_from_path(llava_lora_path)",which actually means "model_name = ART_GuideModel"
however, in "def load_pretrained_model ",if i want to load llava model fine-tuned by lora, model_name should contain "llava" and "lora".
Should I change model_name?

@GuanlinLee
Copy link
Owner

Yes, you are right. When we upload our lora model to the huggingface, we forget that the llava builder has a strict name matching. So, please simply rename the folder from ART_GuideModel to something like llava-lora-mistral, which is used in our local machine.

We will add a note in the ReadMe. Thanks for pointing out it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants