fix: onWindowFocus - returned stop function does not clear visibility…

…change listener
GreatAuk · Feb 26, 2024 · 0c8ff48 · 0c8ff48
1 parent 4f87c65
commit 0c8ff48
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/core/src/onWindowFocus.ts b/packages/core/src/onWindowFocus.ts
@@ -18,14 +18,16 @@ import { debounce } from './vendor'
 export function onWindowFocus(callback: (...args: any[]) => any) {
   const listener = debounce(100, callback)
 
-  window.addEventListener('focus', listener, false)
-  window.addEventListener('visibilitychange', () => {
+  const visibilitychangeListener = () => {
     if (document.visibilityState === 'visible')
       listener()
-  }, false)
+  }
+
+  window.addEventListener('focus', listener, false)
+  window.addEventListener('visibilitychange', visibilitychangeListener, false)
 
   return () => {
     window.removeEventListener('focus', listener)
-    window.removeEventListener('visibilitychange', listener)
+    window.removeEventListener('visibilitychange', visibilitychangeListener)
   }
 }