Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3P Media: Add category filter for Coverr #8814

Closed
swissspidy opened this issue Aug 26, 2021 · 3 comments · Fixed by #12045
Closed

3P Media: Add category filter for Coverr #8814

swissspidy opened this issue Aug 26, 2021 · 3 comments · Fixed by #12045
Assignees
@timarney @felipebochehin87
Labels
Group: 3P Media Third-party media provider integrations. P2 Should do soon Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

Feature Description

Currently blocked by b/197847990 on the 3P Media API side.

The idea is to offer the same category filters for Coverr as we already do for Unsplash and Tenor.

Alternatives Considered

Additional Context
@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature Status: Blocked On hold for the time being Pod: WP & Infra Group: 3P Media Third-party media provider integrations. labels Aug 26, 2021
@swissspidy swissspidy added the P3 Nice to have label Nov 11, 2021
@swissspidy swissspidy removed their assignment Jul 27, 2022
@swissspidy

This comment was marked as outdated.

Sign in to view
@swissspidy swissspidy added P2 Should do soon and removed P3 Nice to have Status: Blocked On hold for the time being labels Jul 27, 2022
@swissspidy
Copy link
Collaborator Author

@timarney FYI this is now unblocked and available in the API, so we're good to go for implementing it in the editor

@timarney timarney mentioned this issue Aug 1, 2022
Merged
8 tasks
@felipebochehin87
Copy link

Tested against https://stories-qa-wordpress-amp.pantheonsite.io/wp-admin/, using PR #12045.

Tested in Firefox, Chrome and Safari, as an Admin, an Author, an Editor and a Contributor.

Clicking on a pill filters videos by that subject;
Clicking again on the same pill clears selection and resets results to "All".

https://images.zenhubusercontent.com/235435637/33f9a223-5aac-4d0a-9fb4-abad0d9b2cd6/2022_08_04_10_09_10.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timarney timarney

@felipebochehin87 felipebochehin87

Labels
Group: 3P Media Third-party media provider integrations. P2 Should do soon Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3P Media: Add category filter for Coverr GoogleForCreators/web-stories-wp
3 participants
@timarney @swissspidy @felipebochehin87