Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Consolidating the FilterProvider to include Author Filter #11620

Closed
sblinde opened this issue Jun 1, 2022 · 5 comments · Fixed by #11736
Closed

Dashboard: Consolidating the FilterProvider to include Author Filter #11620

sblinde opened this issue Jun 1, 2022 · 5 comments · Fixed by #11736
Assignees
Labels
Package: Dashboard /packages/dashboard Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Enhancement New feature or improvement of an existing feature

Comments

@sblinde
Copy link
Contributor

sblinde commented Jun 1, 2022

Feature Description

As part of the feature for Dashboard: Filter by Taxonomy (#11436), our team had to make a larger Filter Provider that held information specific to Taxonomies in order to properly create filters. However, the logic between the Filter by Author work and the Filter by Taxonomy work is separate, in two different places.

This body of work is to unite the two into the larger FilterProvider, so that as we continue onto more filter work in the future (see: #11586), we have one space that holds the logic for each filter, based on the logic of each type of filter that's needed.

This story will block the work needed to accomplish #11586, as it would be better to improve upon the filter provider the team has built before moving on to adding more filters within the Dashboard space.

This tackles both Code Quality and an Enhancement, supporting further filter work, and improving upon the work delivered by #11436.

Acceptance Criteria

  • Both the Taxonomies filters and the Author filters will exist under one FilterProvider
  • Adding another filter in the future should be made easier by this work: this work should allow one to extend the filters as needed for future work

Alternatives Considered

The alternative would be moving forward to add more filters, which would add more separation between filters (which is what exists today with the last body of work to support Filtering by Taxonomies). It would be ideal if we could accomplish this body of tech debt work prior to that work.

Additional Context

@sblinde sblinde added Type: Enhancement New feature or improvement of an existing feature Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Pod: Pea Package: Dashboard /packages/dashboard labels Jun 1, 2022
@swissspidy
Copy link
Collaborator

Appreciate you all keeping an eye on code quality 👍 🚀

@sblinde
Copy link
Contributor Author

sblinde commented Jun 8, 2022

As part of this body of work, it'd be great if we could do what was suggested by @swissspidy:

#11625 (comment)

@swissspidy
Copy link
Collaborator

Another thing I mentioned at #11625 (comment) is to show the taxonomies & author filters also on the list view

Might be something we can do as part of this ticket as well.

@sblinde sblinde changed the title Dashboard: Improve Filters and Move Author Filter to FilterProvider Dashboard: Consolidating the FilterProvider to include Author Filter Jun 9, 2022
@sblinde
Copy link
Contributor Author

sblinde commented Jun 9, 2022

Please add your planning poker estimate with ZenHub @mwritter

@mwritter mwritter self-assigned this Jun 14, 2022
@mwritter
Copy link
Contributor

https://user-images.githubusercontent.com/14057928/173854259-6aaf2224-b3db-4c49-a324-bdeda906db05.mp4
Currently we're making a request on every key stroke to search within the 'datalist' - will fix here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Dashboard /packages/dashboard Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants