-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Consolidating the FilterProvider to include Author Filter #11620
Comments
Appreciate you all keeping an eye on code quality 👍 🚀 |
As part of this body of work, it'd be great if we could do what was suggested by @swissspidy: |
Another thing I mentioned at #11625 (comment) is to show the taxonomies & author filters also on the list view Might be something we can do as part of this ticket as well. |
Please add your planning poker estimate with ZenHub @mwritter |
https://user-images.githubusercontent.com/14057928/173854259-6aaf2224-b3db-4c49-a324-bdeda906db05.mp4 |
Feature Description
As part of the feature for Dashboard: Filter by Taxonomy (#11436), our team had to make a larger Filter Provider that held information specific to Taxonomies in order to properly create filters. However, the logic between the Filter by Author work and the Filter by Taxonomy work is separate, in two different places.
This body of work is to unite the two into the larger FilterProvider, so that as we continue onto more filter work in the future (see: #11586), we have one space that holds the logic for each filter, based on the logic of each type of filter that's needed.
This story will block the work needed to accomplish #11586, as it would be better to improve upon the filter provider the team has built before moving on to adding more filters within the Dashboard space.
This tackles both Code Quality and an Enhancement, supporting further filter work, and improving upon the work delivered by #11436.
Acceptance Criteria
FilterProvider
Alternatives Considered
The alternative would be moving forward to add more filters, which would add more separation between filters (which is what exists today with the last body of work to support Filtering by Taxonomies). It would be ideal if we could accomplish this body of tech debt work prior to that work.
Additional Context
The text was updated successfully, but these errors were encountered: