Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import apply-setter function to skaffold to replace kpt command call for parameterization #8901

Closed
ericzzzzzzz opened this issue Jun 20, 2023 · 1 comment · Fixed by #8902
Assignees
Labels
area/render priority/p0 Highest priority. We are actively looking at delivering it.
Milestone

Comments

@ericzzzzzzz
Copy link
Contributor

ericzzzzzzz commented Jun 20, 2023

  • feat: parameterization  #8365 implemented initial parameterization with kpt native approach by applying krm functions.
  • The downside is that approach requires pulling images with external network, CD(continuous deployment) pipelines may not have that configured.
  • The apply-setter is no longer under maintained.
  • Also, pulling images can be slow as to the normal render phase
  • In addition, if we import that function directly to skaffold, people who use paramaterization for kustomize, kubectl don't need to have kpt installed.
  • We're also able to rename the commenter syntax,

Ask

  • The Ask here is to change the way we parameterize manifests when using kustomize render or raw manifests by using apply-setter function in skaffold directly.
  • We should also use the new name for replacement commenter, so users won't be under the impression that they need kpt for parameterization.
@ericzzzzzzz ericzzzzzzz self-assigned this Jun 20, 2023
@ericzzzzzzz ericzzzzzzz added priority/p0 Highest priority. We are actively looking at delivering it. area/render labels Jun 20, 2023
@ericzzzzzzz
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/render priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant