Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skaffold should not validate kpt version #8306

Closed
ericzzzzzzz opened this issue Jan 9, 2023 · 2 comments · Fixed by #8425
Closed

Skaffold should not validate kpt version #8306

ericzzzzzzz opened this issue Jan 9, 2023 · 2 comments · Fixed by #8425
Assignees
Labels
deploy/kpt kind/friction Issues causing user pain that do not have a workaround kind/todo implementation task/epic for the skaffold team priority/p2 May take a couple of releases release/new-feature
Milestone

Comments

@ericzzzzzzz
Copy link
Contributor

ericzzzzzzz commented Jan 9, 2023

Information

  • Skaffold currently has a validation against kpt version on kpt render, deployer
    func validateKptRendererVersion(cfg *parser.SkaffoldConfigEntry, dc latest.DeployConfig, rc latest.RenderConfig) (cfgErrs []ErrorWithLocation) {
  • The validation was added due to a change introduced by kpt where kpt fn source xxx include meta-resources(Kptfile) content in its output
  • If skaffold deploys the output with a non-kpt deployer, the deploy attempt will fail
  • Even we don't want deployments to fail, we shouldn't set maxVersion limit for kpt, or we may just don't use kpt beta version at all .
    • Setting the maxVersion can prevent users from new kpt, users have to make a choice between to use skaffold and using new version kpt for new features and bug fixes. This is a bit frustrating.
    • Also, if even users want to sacrifice the new stuff in a higher version of kpt, downgrading tool usually is not very pleasant experience
  • We should remove the validation for kpt version and remove extra Kptfile content in the output manifest on skaffold end.
@ericzzzzzzz
Copy link
Contributor Author

  • Kpt has a deprecated flag to toggle whether including Kptfile content into output for kpt fn source .. command, this is deprecated and not working with false

@aaron-prindle aaron-prindle added kind/todo implementation task/epic for the skaffold team deploy/kpt release/new-feature kind/friction Issues causing user pain that do not have a workaround priority/p2 May take a couple of releases labels Jan 9, 2023
@ericzzzzzzz ericzzzzzzz added this to the v2.2.0 milestone Jan 26, 2023
@ericzzzzzzz ericzzzzzzz self-assigned this Jan 26, 2023
@ericzzzzzzz
Copy link
Contributor Author

Let's include "upgrading kpt version in skaffold image" into the issue scope as well .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy/kpt kind/friction Issues causing user pain that do not have a workaround kind/todo implementation task/epic for the skaffold team priority/p2 May take a couple of releases release/new-feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants