From 9b9140987757d61f6b4217dcf89aede1dcfef969 Mon Sep 17 00:00:00 2001 From: Benjamin Kaplan Date: Thu, 12 Sep 2024 11:31:59 -0700 Subject: [PATCH] fix: have empty url instead of dash in cloud run service ready event if no URL is available --- pkg/skaffold/deploy/cloudrun/status.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pkg/skaffold/deploy/cloudrun/status.go b/pkg/skaffold/deploy/cloudrun/status.go index 709fa46d1df..aef7abea5cc 100644 --- a/pkg/skaffold/deploy/cloudrun/status.go +++ b/pkg/skaffold/deploy/cloudrun/status.go @@ -345,11 +345,6 @@ func (r *runServiceResource) getTerminalStatus(crClient *run.APIService) (*run.G } func (r *runServiceResource) reportSuccess() { url := r.url - if url == "" { - // a URL may not be present if the default URL is disabled. Use - instead of empty in case anyone is parsing the - // event status - url = "-" - } eventV2.CloudRunServiceReady(r.path, url, r.latestRevision) }