Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ignored files also removes the Dockerfile #422

Closed
jeff-knurek opened this issue Oct 31, 2018 · 1 comment · Fixed by #424
Closed

Removing ignored files also removes the Dockerfile #422

jeff-knurek opened this issue Oct 31, 2018 · 1 comment · Fixed by #424

Comments

@jeff-knurek
Copy link

Actual behavior
After this change: 6ef616b
there is the potential to delete the Dockerfile that in the next step of building is no longer in the context

To Reproduce
in the .dockerignore, add something like:

*
!bin
!scripts/*.sh

this results in:

INFO[0000] Removing ignored files from build context: [* !bin !scripts/*.sh] 
Error: please provide a valid path to a Dockerfile within the build context with --dockerfile
@priyawadhwa
Copy link
Collaborator

Hey @jeff-knurek , this issue should be fixed with #424, please comment on this thread or open another issue if you run into any more bugs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants