Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow --no-push configuration through environment variable #2385

Open
73VW opened this issue Feb 3, 2023 · 0 comments
Open
Labels
area/env-variable fix-suggested good first issue Good for newcomers help wanted Looking for a volunteer! kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@73VW
Copy link

73VW commented Feb 3, 2023

Hello everyone,

I won't use the bug issue template because this is not a bug report but a request for new functionality.

We run our container builds using shell scripts and would prefer to be able to set an environment variable for skipping push when building the images in merge/pull requests for example.
That would allow to keep build script as they are and only set a variable from the job configuration.

My idea is to do the same as for the KANIKO_REGISTRY_MIRROR variable.
The variable could be called KANIKO_NO_PUSH for example.

I am not a Go developper so I have no idea how to parse environment variable but I guess it might quite similar to what is done here.
If someone can confirm, I could open a PR to add what's missing. If it is more complicated, I won't be able to help.

Linking #144 because it was the original issue about building without pushing.

Thanks in advance.
Cheers

@aaron-prindle aaron-prindle added area/env-variable fix-suggested help wanted Looking for a volunteer! good first issue Good for newcomers kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/env-variable fix-suggested good first issue Good for newcomers help wanted Looking for a volunteer! kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

No branches or pull requests

2 participants