Adds SourceImage and has Jib#from also take RegistryImage. #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
reviewed
Sep 18, 2018
| @@ -39,7 +39,7 @@ | |||
| * credentials are valid push credentials for the repository specified via the image reference. | |||
| */ | |||
| // TODO: Add tests once JibContainerBuilder#containerize() is added. | |||
| public class RegistryImage implements TargetImage { | |||
| public class RegistryImage implements SourceImage, TargetImage { | |||
There was a problem hiding this comment.
With this change, the Javadoc needs to be updated too. For example, "Builds to a container registry", "which registry to push the image to", "the namespace to push the image to".
chanseokoh
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regards #987 (comment)