Proposal RFC: Jib Core as a library for Java #987
Conversation
| - `JibContainerBuilder setExposedPorts(List<Port>/Port...)` | ||
| - `JibContainerBuilder addExposedPort(Port port)` | ||
| - `JibContainerBuilder setLabels(Map<String, String> labelMap)` | ||
| - `JibContainerBuilder addLabel(String key, String value)` |
There was a problem hiding this comment.
Weren't we talking about having a more fluent-looking environment(), labels()?
There was a problem hiding this comment.
Right, that was in #953 - I'll update these to reflect the proposal there.
There was a problem hiding this comment.
Actually, after changing this over, I feel like the way we have it now is clearer, since there's a combination of set... and add... methods and removing the prefixes may be confusing since most of the set... methods mean "replace with" rather than "append".
There was a problem hiding this comment.
Scratch that - I'll rework this with the setters changed into the ...Only names.
There was a problem hiding this comment.
Hmm, but for setters like setLayers, layersOnly or the like doesn't sound right.
There was a problem hiding this comment.
And just layers is unclear as to whether it appends or replaces.
There was a problem hiding this comment.
But I don't think we ever replace layers, do we. At least, not for the API. Right?
There was a problem hiding this comment.
setLayers currently would actually replace layers (https://github.com/GoogleContainerTools/jib/blob/master/jib-core/src/main/java/com/google/cloud/tools/jib/api/JibContainerBuilder.java#L109)
|
Thought about the |
proposals/jib_core_library.md
Outdated
|
|
||
| `JibContainerBuilder` - configures the container to build | ||
| - `JibContainerBuilder layer(List<Path> files, Path pathInContainer)` | ||
| - `JibContainerBuilder layer(LayerConfiguration)` |
There was a problem hiding this comment.
These two were changed to addLayer, right?
There was a problem hiding this comment.
Yep, I'll change this over.
|
Merged, but final API may be subject to change. |
For #337
Preview at: https://github.com/GoogleContainerTools/jib/blob/jib-core-proposal/proposals/jib_core_library.md
Note that the proposed API is currently in implementation.