-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎁 Jib CLI > Add the windows install process with chocolatey 🎁 #3201
Conversation
Hi, I'm a Jib 💌 Most of the time, i'm running Jib from `maven` and `gradle` , but recently I had to use it from command line. To help windows colleagues adopt it, I created a [Chocolatey package](https://community.chocolatey.org/packages/jib) to make the install process even easier under windows. Hopefully you'll like it. Thanks a lot for Jib, it helps us save so much time ! https://twitter.com/rastadidi/status/1380255793648312321 Kind Regards, Adrien
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #3201 +/- ##
=========================================
Coverage 71.24% 71.24%
Complexity 2328 2328
=========================================
Files 279 279
Lines 9844 9844
Branches 977 977
=========================================
Hits 7013 7013
Misses 2493 2493
Partials 338 338 Continue to review full report at Codecov.
|
CLA ✔️ |
@adriens oh, awesome! Basically I don't really know what chocolatey is or have a way to test this, but sounds like this can be really helpful to the users. For the CLA check, I also verified you are signed. I think you just need to leave a comment here with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks a lot for creating the package!
I've updated the doc slightly. Generally we want to be concise. 😄
We only need to take care of the CLA. Other than that, LGTM.
@googlebot I signed it! |
@chanseokoh : thanks a lot for your very kind feedback. |
Thanks! Merging now. |
Hi, I'm a Jib fan.
Most of the time, i'm running Jib from
maven
andgradle
, but recently I had to use it from command line. To help windows colleagues adopt it, I created a Chocolatey package to make the install process even easier under windows.Hopefully you'll like it.
Thanks a lot for Jib, it helps us save so much time !
https://twitter.com/rastadidi/status/1380255793648312321
Kind Regards,
Adrien