Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Jib CLI > Add the windows install process with chocolatey 🎁 #3201

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

adriens
Copy link
Contributor

@adriens adriens commented Apr 9, 2021

Hi, I'm a Jib fan.
Most of the time, i'm running Jib from maven and gradle , but recently I had to use it from command line. To help windows colleagues adopt it, I created a Chocolatey package to make the install process even easier under windows.

Hopefully you'll like it.

Thanks a lot for Jib, it helps us save so much time !

https://twitter.com/rastadidi/status/1380255793648312321

Kind Regards,
Adrien

Hi, I'm a Jib 💌 
Most of the time, i'm running Jib from `maven` and `gradle` , but recently I had to use it from command line. To help windows colleagues adopt it, I created a [Chocolatey package](https://community.chocolatey.org/packages/jib) to make the install process even easier under windows.

Hopefully you'll like it.

Thanks a lot for Jib, it helps us save so much time !


https://twitter.com/rastadidi/status/1380255793648312321

Kind Regards,
Adrien
@google-cla

This comment has been minimized.

@google-cla google-cla bot added the cla: no label Apr 9, 2021
@adriens adriens changed the title 🎁 Add the windows install process with chocolatey 🎁 🎁 Jib CLI > Add the windows install process with chocolatey 🎁 Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #3201 (9c3699c) into master (75a3326) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3201   +/-   ##
=========================================
  Coverage     71.24%   71.24%           
  Complexity     2328     2328           
=========================================
  Files           279      279           
  Lines          9844     9844           
  Branches        977      977           
=========================================
  Hits           7013     7013           
  Misses         2493     2493           
  Partials        338      338           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a3326...9c3699c. Read the comment docs.

@adriens
Copy link
Contributor Author

adriens commented Apr 9, 2021

CLA ✔️

@adriens
Copy link
Contributor Author

adriens commented Apr 9, 2021

image

@chanseokoh
Copy link
Member

@adriens oh, awesome! Basically I don't really know what chocolatey is or have a way to test this, but sounds like this can be really helpful to the users.

For the CLA check, I also verified you are signed. I think you just need to leave a comment here with @googlebot I signed it! per instructions.

Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks a lot for creating the package!

I've updated the doc slightly. Generally we want to be concise. 😄

We only need to take care of the CLA. Other than that, LGTM.

@adriens
Copy link
Contributor Author

adriens commented Apr 12, 2021

@googlebot I signed it!

@adriens
Copy link
Contributor Author

adriens commented Apr 12, 2021

@chanseokoh : thanks a lot for your very kind feedback.
Jib is an amazing tool, making us so productive 👏 🚀

@chanseokoh
Copy link
Member

Thanks! Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants