From 2ba69c76aef9e756133b9bbd39c9274210a45379 Mon Sep 17 00:00:00 2001 From: Takashi Matsuo Date: Wed, 22 Jul 2020 22:56:12 +0000 Subject: [PATCH 1/3] fix(translate): fix a broken test fixes #4353 --- translate/automl/model_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/translate/automl/model_test.py b/translate/automl/model_test.py index e19a50ea7376..fd2fabc38a7d 100644 --- a/translate/automl/model_test.py +++ b/translate/automl/model_test.py @@ -77,4 +77,4 @@ def test_model_list_get_evaluate(capsys): project_id, compute_region, model_id, model_evaluation_id ) out, _ = capsys.readouterr() - assert "evaluation_metric" in out + assert model_evaluation_id in out From ae07752f2fecc387288d0e400233ddd8ab273c24 Mon Sep 17 00:00:00 2001 From: Takashi Matsuo Date: Thu, 23 Jul 2020 16:45:42 +0000 Subject: [PATCH 2/3] use uuid --- translate/automl/dataset_test.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/translate/automl/dataset_test.py b/translate/automl/dataset_test.py index 4430ec5400e0..d5478ace51fd 100644 --- a/translate/automl/dataset_test.py +++ b/translate/automl/dataset_test.py @@ -14,8 +14,8 @@ # See the License for the specific language governing permissions and # limitations under the License. -import datetime import os +import uuid import pytest @@ -24,11 +24,10 @@ project_id = os.environ["GOOGLE_CLOUD_PROJECT"] compute_region = "us-central1" - @pytest.mark.slow def test_dataset_create_import_delete(capsys): # create dataset - dataset_name = "test_" + datetime.datetime.now().strftime("%Y%m%d%H%M%S") + dataset_name = f"test_{uuid.uuid4().hex}" automl_translation_dataset.create_dataset( project_id, compute_region, dataset_name, "en", "ja" ) From c26a42edc70c79662ea98edc8d9b0c09ead8ea6f Mon Sep 17 00:00:00 2001 From: Takashi Matsuo Date: Thu, 23 Jul 2020 18:15:50 +0000 Subject: [PATCH 3/3] fix builds --- translate/automl/dataset_test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/translate/automl/dataset_test.py b/translate/automl/dataset_test.py index d5478ace51fd..eb5796d58c04 100644 --- a/translate/automl/dataset_test.py +++ b/translate/automl/dataset_test.py @@ -24,10 +24,11 @@ project_id = os.environ["GOOGLE_CLOUD_PROJECT"] compute_region = "us-central1" + @pytest.mark.slow def test_dataset_create_import_delete(capsys): # create dataset - dataset_name = f"test_{uuid.uuid4().hex}" + dataset_name = f"test_{uuid.uuid4().hex[:27]}" automl_translation_dataset.create_dataset( project_id, compute_region, dataset_name, "en", "ja" )