Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "gcp.resource_type" resource attribute #85

Closed
aabmass opened this issue Oct 26, 2020 · 1 comment
Closed

Remove "gcp.resource_type" resource attribute #85

aabmass opened this issue Oct 26, 2020 · 1 comment

Comments

@aabmass
Copy link
Collaborator

aabmass commented Oct 26, 2020

Instead, use OTel resource semantic conventions. See Go reference impl https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/402639db27fdf8e5143cfd8a871d40cbe10d4bd2/exporter/metric/metric.go#L365

@aabmass
Copy link
Collaborator Author

aabmass commented Nov 30, 2022

This was fixed in #214

@aabmass aabmass closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants