Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLInstance missing support for transactionLogRetentionDays #419

Closed
isaacseymour opened this issue Mar 4, 2021 · 5 comments
Closed

SQLInstance missing support for transactionLogRetentionDays #419

isaacseymour opened this issue Mar 4, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@isaacseymour
Copy link

Describe the feature or resource
The SQLInstance resource does not have an option for setting transactionLogRetentionDays. This is available in the REST API

Importance
This is a pain point, since this setting can be modified in the GCP Console, but when it's not in the config-as-code there's no documentation about what the setting should be and why.

@isaacseymour isaacseymour added the enhancement New feature or request label Mar 4, 2021
@maqiuyujoyce
Copy link
Collaborator

Hi @isaacseymour , thank you for your request. We'll be looking into prioritizing it.

Just to share some context - The SQLInstance resource is supported on top of the Terraform resource, google_sql_database_instance, and Config Connector will support transactionLogRetentionDays after the TF resource supports it. Currently there is an open enhancement request for supporting this particular field. Will keep you posted when we have any updates.

@isaacseymour
Copy link
Author

Aha! Looks like that request is being closed in the unreleased version of the terraform provider, so hopefully that won't be a blocker for much longer! Thanks for the speedy reply :)

@isaacseymour
Copy link
Author

Looks like this was added to the Google Terraform provider in 3.60.0. Is there another issue I should be following to track when that update will be included in config-connector?

@maqiuyujoyce
Copy link
Collaborator

Hi @isaacseymour , transactionLogRetentionDays in SQLInstance has been supported in Config Connector 1.44.0. Please let us know if you have any additional questions.

@isaacseymour
Copy link
Author

Oh amazing! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants