Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to require multiple approvals #55

Closed
rojomisin opened this issue Mar 15, 2023 · 3 comments
Closed

ability to require multiple approvals #55

rojomisin opened this issue Mar 15, 2023 · 3 comments
Labels
enhancement New feature or request next-release

Comments

@rojomisin
Copy link

One feature that would be useful for the MPA worklfows is to set to have MIN_APPROVERS=2, where if there's 5 ACTIVATION_REQUEST_MAX_REVIEWERS in the list, 2 would be required, otherwise default to 1 approval only.

@jpassing
Copy link
Collaborator

jpassing commented Mar 15, 2023 via email

@jpassing jpassing added the enhancement New feature or request label Mar 23, 2023
@rojomisin
Copy link
Author

I assume the lack of state being the reason 2 is more difficult, yeah honestly the Slack feature might help w/ visibility and awareness of approvals amongst peers. The feedback originally was that some only check their email once a day.

Implementation of 1 could be a slight boost as well, otherwise someone might just try and skirt around the more scrutinizing senior members, and opt to get approval from the intern :)

@jpassing
Copy link
Collaborator

This feature is now available in release 1.4, see ACTIVATION_REQUEST_MIN_REVIEWERS, ACTIVATION_REQUEST_MAX_REVIEWERS.

Thanks again for the feature suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next-release
Projects
None yet
Development

No branches or pull requests

2 participants