Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a time interval option in the JIT access request UI #52

Closed
dneduva-cisco opened this issue Mar 9, 2023 · 6 comments
Closed

Add a time interval option in the JIT access request UI #52

dneduva-cisco opened this issue Mar 9, 2023 · 6 comments
Labels
enhancement New feature or request next-release

Comments

@dneduva-cisco
Copy link

As an enhancement, we would like the option to request the amount of time a user is given access to a certain role in JIT as part of the request.
We would like that to be an option in the JIT UI instead of an environment variable in the app.yaml.

@jpassing
Copy link
Collaborator

jpassing commented Mar 9, 2023

I agree that this would be a useful feature. The ACTIVATION_TIMEOUT (in app.yaml) would then define an upper bound (for ex, 2h). Users could choose to activate a role for a shorter period of time (for ex, only 30min), but couldn't go beyond that upper bound.

@jpassing jpassing added the enhancement New feature or request label Mar 9, 2023
@lnrdll
Copy link

lnrdll commented Mar 21, 2023

+1

@jpassing
Copy link
Collaborator

This feature is now available in release 1.4: You can now choose the duration for which to activate a role, between 5 minutes and the maximum duration specified by ACTIVATION_TIMEOUT.

@lnrdll
Copy link

lnrdll commented Apr 19, 2023

Could we log the duration for which the user has requested elevation?

@jpassing
Copy link
Collaborator

The logs contain the start and end date in the activation_start and activation_end labels:

image

This (implicitly) gives you the duration. We could add an extra label for duration, but I guess it would be somewhat redundant?

@lnrdll
Copy link

lnrdll commented Apr 22, 2023

I think I overlooked these entries. No need for an extra label. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next-release
Projects
None yet
Development

No branches or pull requests

3 participants