Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions.SlackSlashCommandTest: handlesPopulatedKgResultsTest failed #6467

Closed
flaky-bot bot opened this issue Dec 4, 2021 · 8 comments · Fixed by #6668
Closed

functions.SlackSlashCommandTest: handlesPopulatedKgResultsTest failed #6467

flaky-bot bot opened this issue Dec 4, 2021 · 8 comments · Fixed by #6668
Assignees
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Dec 4, 2021

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.


commit: 3386f9e
buildURL: Build Status, Sponge
status: failed

Test output
expected to contain: https://en.wikipedia.org/wiki/Lion
but was            : {"response_type":"in_channel","text":"Query: lion","attachments":[{"title":"Osama bin Laden","title_link":"https://en.wikipedia.org/wiki/Osama_bin_Laden","text":"Osama bin Mohammed bin Awad bin Laden, also transliterated as Usama bin Ladin, was a Saudi Arabian terrorist and founder of the Pan-Islamic militant organization al-Qaeda. "}]}
	at functions.SlackSlashCommandTest.handlesPopulatedKgResultsTest(SlackSlashCommandTest.java:162)
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 4, 2021
@product-auto-label product-auto-label bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Dec 4, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Dec 5, 2021

commit: 0303f32
buildURL: Build Status, Sponge
status: failed

Test output
expected to contain: https://en.wikipedia.org/wiki/Lion
but was            : {"response_type":"in_channel","text":"Query: lion","attachments":[{"title":"Osama bin Laden","title_link":"https://en.wikipedia.org/wiki/Osama_bin_Laden","text":"Osama bin Mohammed bin Awad bin Laden, also transliterated as Usama bin Ladin, was a Saudi Arabian terrorist and founder of the Pan-Islamic militant organization al-Qaeda. "}]}
	at functions.SlackSlashCommandTest.handlesPopulatedKgResultsTest(SlackSlashCommandTest.java:162)

@flaky-bot
Copy link
Author

flaky-bot bot commented Dec 8, 2021

commit: b186aa1
buildURL: Build Status, Sponge
status: failed

Test output
expected to contain: https://en.wikipedia.org/wiki/Lion
but was            : {"response_type":"in_channel","text":"Query: lion","attachments":[{"title":"Osama bin Laden","title_link":"https://en.wikipedia.org/wiki/Osama_bin_Laden","text":"Osama bin Mohammed bin Awad bin Laden, also transliterated as Usama bin Ladin, was a Saudi Arabian terrorist and founder of the Pan-Islamic militant organization al-Qaeda. "}]}
	at functions.SlackSlashCommandTest.handlesPopulatedKgResultsTest(SlackSlashCommandTest.java:162)

@flaky-bot
Copy link
Author

flaky-bot bot commented Dec 9, 2021

commit: da76a21
buildURL: Build Status, Sponge
status: failed

Test output
expected to contain: https://en.wikipedia.org/wiki/Lion
but was            : {"response_type":"in_channel","text":"Query: lion","attachments":[{"title":"Osama bin Laden","title_link":"https://en.wikipedia.org/wiki/Osama_bin_Laden","text":"Osama bin Mohammed bin Awad bin Laden, also transliterated as Usama bin Ladin, was a Saudi Arabian terrorist and founder of the Pan-Islamic militant organization al-Qaeda. "}]}
	at functions.SlackSlashCommandTest.handlesPopulatedKgResultsTest(SlackSlashCommandTest.java:162)

@lesv
Copy link
Contributor

lesv commented Dec 9, 2021

Let's see if it reopens

@lesv lesv closed this as completed Dec 9, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Dec 11, 2021

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


commit: 4c44a75
buildURL: Build Status, Sponge
status: failed

Test output
expected to contain: https://en.wikipedia.org/wiki/Lion
but was            : {"response_type":"in_channel","text":"Query: lion","attachments":[{"title":"Osama bin Laden","title_link":"https://en.wikipedia.org/wiki/Osama_bin_Laden","text":"Osama bin Mohammed bin Awad bin Laden, also transliterated as Usama bin Ladin, was a Saudi Arabian terrorist and founder of the Pan-Islamic militant organization al-Qaeda. "}]}
	at functions.SlackSlashCommandTest.handlesPopulatedKgResultsTest(SlackSlashCommandTest.java:162)

@flaky-bot flaky-bot bot reopened this Dec 11, 2021
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Dec 11, 2021
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Dec 11, 2021
@anguillanneuf anguillanneuf assigned ace-n and unassigned anguillanneuf Dec 14, 2021
@ace-n
Copy link
Contributor

ace-n commented Dec 15, 2021

This looks like an API-level issue.

@lesv @anguillanneuf I see two possible options:

  1. change what we search for in the test to something more unique (i.e. with fewer collisions on Wikipedia)
  2. wait and see if this starts passing given more time

Which would y'all prefer?

@lesv
Copy link
Contributor

lesv commented Dec 15, 2021

I'm going to close this to see if it is fixed - we re-did the SA's and IAM's after they were deleted by an errant app, it took us a bit to get things right. (ie. I'm picking #2) If there is still a problem, then let's talk.

@lesv lesv closed this as completed Dec 15, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Dec 22, 2021

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 571cf0f
buildURL: Build Status, Sponge
status: failed

Test output
expected to contain: https://en.wikipedia.org/wiki/Lion
but was            : {"response_type":"in_channel","text":"Query: lion","attachments":[{"title":"Osama bin Laden","title_link":"https://en.wikipedia.org/wiki/Osama_bin_Laden","text":"Osama bin Mohammed bin Awad bin Laden, also transliterated as Usama bin Ladin, was a Saudi Arabian terrorist and founder of the Pan-Islamic militant organization al-Qaeda. "}]}
	at functions.SlackSlashCommandTest.handlesPopulatedKgResultsTest(SlackSlashCommandTest.java:162)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@lesv @ace-n @anguillanneuf @yoshi-automation and others