-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve separate web app manifest for admin #295
Comments
One thing needing to determine is whether the favicon for the site should be used or else a WordPress logo should be used as the icon in the manifest. In WordPress/gutenberg#33102, @ellatrix implemented the latter along with customizing the logo to reflect the admin color scheme. However, I'm thinking the favicon actually should be used instead because the Site Icon (favicon) set in the Customizer is used both on the frontend and admin alike. The |
If the icon is the same, then what will be needed is a way to differentiate the frontend app from the admin app. Currently the site title is used for the |
While Gutenberg is inlining the web app manifest as a Nevertheless, one complication is extensibility. Currently there is one web app manifest and it is accessible via the REST API at |
Maybe we could use a
But that is probably an abuse of that parameter. |
We can use a |
Not a high priority for 0.7 since the web app manifest is being removed from Gutenberg in WordPress/gutenberg#38810 which was causing a conflict. This could wait until we are actually leveraging service worker capabilities in the admin. Until then, there's not really any need to have the admin be a separate PWA to install. |
I was doing some more research on this and I found Multiple Language Installable Web Apps using a single Manifest File which also explores the technique of using a
For i18n, a better approach is probably going to be to add a |
Proof of concept for an Admin PWA extension plugin: https://gist.github.com/westonruter/0d09371a2b2c991f344fa67b728975c5 |
In order to facilitate adding the WP Admin for a site to the homescreen, we should possibly consider serving a separate web app manifest for the admin alone, to go along with the admin-specific service worker. I think this makes sense because the frontend and the admin are really two separate apps. The alternative would be to add an app shortcut to the main manifest for the admin, but this wouldn't make sense for the vast majority of visitors who never access the admin.
This would resolve #222 wherein errors are being reported in the admin due to their being no manifest.
The text was updated successfully, but these errors were encountered: