Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the keystore usage #254

Closed
dandv opened this issue Jul 21, 2020 · 2 comments · Fixed by #265
Closed

Clarify the keystore usage #254

dandv opened this issue Jul 21, 2020 · 2 comments · Fixed by #265
Labels
enhancement New feature or request

Comments

@dandv
Copy link
Contributor

dandv commented Jul 21, 2020

Is your feature request related to a problem? Please describe.
For web developers unfamiliar with android, the keystore may be confusing.

Describe the solution you'd like
While running bubblewrap build,

? Password for the Key Store

can be interpreted as both "What is the password for the keystore", and "Set a password for the keystore"

Same for

? Password for the Key:

The previous prompts are ambiguous as well. I ended up creating a directory ("store"):

? Key store location: ./android.keystore
? Key name: ./android.keystore

Then I got this error,

Failed to load signer "signer #1"
java.io.FileNotFoundException: ./android.keystore (Is a directory)

Describe alternatives you've considered
PWABuilder?

Additional context
Ideally, a web dev who's never touched Android development, should be able to build a TWA from their PWA.

@andreban
Copy link
Member

Regarding the key store location and name prompts, we recently introduced an explanation right before the questions. There's a bug where the default alias should be android instead of ./android.keystore. Builds still work though.

Screen Shot 2020-07-21 at 07 53 02

We could add more context when asking for the passwords during the build step, similar to the above.

@andreban
Copy link
Member

#255 will fix using the correct alias by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants