Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix existing fit_pts/apply_pts functionalities #475

Closed
rhugonnet opened this issue Feb 7, 2024 · 0 comments · Fixed by #480
Closed

Fix existing fit_pts/apply_pts functionalities #475

rhugonnet opened this issue Feb 7, 2024 · 0 comments · Fixed by #480
Labels
enhancement Feature improvement or request priority Needs to be fixed rapidly

Comments

@rhugonnet
Copy link
Member

There are:

  • Many hard-coded filters that run in the background, such as min_count in _get_horizontal_shift,
  • The input GeoDataFrame in fit_pts expects the x/y values copied in "E" and "N" columns while they are already available,
  • The apply_pts functions expects a different format of a 3 x N np.ndarray...

A lot of homogenization to do!
@rhugonnet rhugonnet added enhancement Feature improvement or request priority Needs to be fixed rapidly labels Feb 7, 2024
@rhugonnet rhugonnet changed the title Fix existing apply_pts functionalities Fix existing fit_pts/apply_pts functionalities Feb 7, 2024
@rhugonnet rhugonnet mentioned this issue Mar 1, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature improvement or request priority Needs to be fixed rapidly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fuse Coreg point functions and add consistent Raster-Point logic rhugonnet/xdem
1 participant
@rhugonnet