Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to turn off name parsing #626

Closed
adehecq opened this issue Nov 2, 2024 · 2 comments · Fixed by #628
Closed

Option to turn off name parsing #626

adehecq opened this issue Nov 2, 2024 · 2 comments · Fixed by #628
Labels
invalid This doesn't seem right

Comments

@adehecq
Copy link
Member

adehecq commented Nov 2, 2024

We had the issue with some students that if we save a DEM with a filename close to the "standard names", the automatic name parsing in xdem.DEM fails because it is not consistent with the expected name. One of the cases that failed was I believe something like "NASADEM_XXX.tif". I can provide a reproducible example if needed, but I don't have the time just now.
I think there should be an option to turn-off name parsing to avoid such conflicts.

@adehecq adehecq added the invalid This doesn't seem right label Nov 2, 2024
@rhugonnet
Copy link
Member

This option exists, it's the read_from_fn parameter, see: https://github.com/GlacioHack/geoutils/blob/e7538d1cd9bec79508fe1452991cbef8c5078bb9/geoutils/raster/satimg.py#L275C16-L275C28.

Maybe we should simply make it False by default, which would be natural if removing the SatelliteImage as proposed here: #532

@rhugonnet
Copy link
Member

Moving this to GeoUtils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
2 participants