Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to pass z_name and random_state for Raster.to_points() #499

Closed
rhugonnet opened this issue Mar 6, 2024 · 3 comments · Fixed by #501
Closed

Allow user to pass z_name and random_state for Raster.to_points() #499

rhugonnet opened this issue Mar 6, 2024 · 3 comments · Fixed by #501
Labels
enhancement Feature improvement or request

Comments

@rhugonnet
Copy link
Member

Right now forced to "b1" without any argument.
Could rename the method into to_pointcloud for clarity?
@rhugonnet
Copy link
Member Author

And allow to pass a random_state!

@rhugonnet rhugonnet changed the title Allow user to pass "z_name" for Raster.to_points() Allow user to pass z_name and random_state for Raster.to_points() Mar 6, 2024
@rhugonnet
Copy link
Member Author

And fix pixel_offset="corner" which fails... Need to make this consistent with interp_points and test it.

@rhugonnet
Copy link
Member Author

Looks like making pixel_offset="ul" the default actually aligns the point with the raster by default (comparing to interp_points).

This was referenced Mar 7, 2024
Merged
Merged
@rhugonnet rhugonnet added the enhancement Feature improvement or request label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature improvement or request
Projects
None yet
Milestone
No milestone
1 participant
@rhugonnet