You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At least using GiphyGridView, if you long-click on a gif, a preview dialog is shown, but if you try to close it with back-button (the most intuitive way), the action is not handled and the activity finishes.
To Reproduce
Long-click on a gif (using GiphyGridView)
Press back button
Expected behavior
It should close the preview dialog.
Another possibility may be that we handle the back action and we close the dialog.
We can enable an OnBackPressedCallback on didLongPressCell but we need a way to programmatically close the preview dialog and another event that needs to be called when the dialog is closed anyway (touching the screen, clicking "select", clicking the author or whatever) to again disable the OnBackPressedCallback
Actual Behavior
It finishes the activity
Your Environment
Giphy Android SDK version: 2.3.9
Device info (Emulator/Device? Android version? Debug/Release?): Samsung Galaxy S9+ -But I guess it happens on all devices-
Reproducible Demo
The text was updated successfully, but these errors were encountered:
santi-petersen
changed the title
[UX] The preview dialog is not closed with the back button in GiphyGridView
[UX] Preview dialog is not closed with the back button in GiphyGridView
Aug 24, 2023
🐛 Bug Report
At least using GiphyGridView, if you long-click on a gif, a preview dialog is shown, but if you try to close it with back-button (the most intuitive way), the action is not handled and the activity finishes.
To Reproduce
Expected behavior
It should close the preview dialog.
Another possibility may be that we handle the back action and we close the dialog.
We can enable an OnBackPressedCallback on didLongPressCell but we need a way to programmatically close the preview dialog and another event that needs to be called when the dialog is closed anyway (touching the screen, clicking "select", clicking the author or whatever) to again disable the OnBackPressedCallback
Actual Behavior
It finishes the activity
Your Environment
Reproducible Demo
The text was updated successfully, but these errors were encountered: