Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Preview dialog is not closed with the back button in GiphyGridView #210

Closed
santi-petersen opened this issue Aug 24, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@santi-petersen
Copy link

santi-petersen commented Aug 24, 2023

🐛 Bug Report

At least using GiphyGridView, if you long-click on a gif, a preview dialog is shown, but if you try to close it with back-button (the most intuitive way), the action is not handled and the activity finishes.

To Reproduce

  1. Long-click on a gif (using GiphyGridView)
  2. Press back button

Expected behavior

It should close the preview dialog.

Another possibility may be that we handle the back action and we close the dialog.
We can enable an OnBackPressedCallback on didLongPressCell but we need a way to programmatically close the preview dialog and another event that needs to be called when the dialog is closed anyway (touching the screen, clicking "select", clicking the author or whatever) to again disable the OnBackPressedCallback

Actual Behavior

It finishes the activity

Your Environment

  • Giphy Android SDK version: 2.3.9
  • Device info (Emulator/Device? Android version? Debug/Release?): Samsung Galaxy S9+ -But I guess it happens on all devices-

Reproducible Demo

@santi-petersen santi-petersen added the bug Something isn't working label Aug 24, 2023
@santi-petersen santi-petersen changed the title [UX] The preview dialog is not closed with the back button in GiphyGridView [UX] Preview dialog is not closed with the back button in GiphyGridView Aug 24, 2023
@ALexanderLonsky
Copy link
Collaborator

Hey @santi-petersen,
Thanks for flagging this issue!
It has been resolved in the new version 2.3.10.

@santi-petersen
Copy link
Author

Hey @santi-petersen, Thanks for flagging this issue! It has been resolved in the new version 2.3.10.

Brilliant! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants