Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin support for Geyser standalone #542

Closed
tlaundal opened this issue May 13, 2020 · 10 comments
Closed

Plugin support for Geyser standalone #542

tlaundal opened this issue May 13, 2020 · 10 comments
Labels
Feature Request A feature request.

Comments

@tlaundal
Copy link

What feature do you want?
Geyser standalone should have a simple infrastructure to load plugins from jar files.

Alternatives?
In lack of plugin support I had to modify the source code for the standalone bootstrap to run my plugin code. In my specific use case the plugin was sending logs and metrics from Geyser to a database for central analysis.

@Heath123
Copy link
Contributor

Geyser used to have a plugin system but it was removed. I can think of a few uses for it (ViaVersion, things that they don't want to add but may be useful to some people) so maybe they should bring it back?

@Redned235
Copy link
Member

What feature do you want?
Geyser standalone should have a simple infrastructure to load plugins from jar files.

Alternatives?
In lack of plugin support I had to modify the source code for the standalone bootstrap to run my plugin code. In my specific use case the plugin was sending logs and metrics from Geyser to a database for central analysis.

This is something we had in the past and ultimately we decided plugins went beyond the scope of what Geyser was trying to accomplish. Most of the reasons we had the plugin API for initially could be done with Floodgate or other plugins installed on the server instead, so we decided to take it out due to that.

@tlaundal
Copy link
Author

Just to provide some more information of my use case, which I think would not be possible to achieve with Floodgate:

  • Get the amount of players connected to each Geyser instance (we are running multiple in parallel)
  • Get memory information about the JVM Geyser is running in
  • Adding a custom log appender to the logger Geyser is using

@williamjohnstone
Copy link
Contributor

You're right, what you want is currently not available from our current implementation, and the only way I can see you achieving what you want is adding plugin support, I think if we want to move in the direction of supporting larger networks (although we're a way from that right now) plugin support is necessary, I'll let the rest of the team know and hopefully we can get something figured out.

@Heath123
Copy link
Contributor

I can see some uses for this too. I think we should consider adding it back.

@Camotoy
Copy link
Member

Camotoy commented May 13, 2020

To give my opinion, there's definitely merit in reviving plugins; I don't think it's a good idea now that 1.16 is surely around the corner, and we are getting closer to feature-perfect. Once that's done I don't see why we can't have a basic plugin API, or giving developers or statistics nerds something to play it.

This was referenced May 21, 2020
@Camotoy
Copy link
Member

Camotoy commented May 28, 2020

Reopening so we don't keep getting issue requests for this.

@Camotoy Camotoy reopened this May 28, 2020
@Camotoy Camotoy added the Feature Request A feature request. label May 28, 2020
@Camotoy Camotoy linked a pull request Jun 17, 2020 that will close this issue
22 tasks
@gougocoffee
Copy link

gougocoffee commented Jun 21, 2020

If only mobile players could display GUI like menus. “ https://github.com/GeyserMC/Geyser/pull/742#issuecomment-640273654”

@Redned235
Copy link
Member

Update: this is now being done in the feature/extensions branch.

@Camotoy
Copy link
Member

Camotoy commented Sep 19, 2022

Update: that branch has been merged.

@Camotoy Camotoy closed this as completed Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A feature request.
Projects
None yet
Development

No branches or pull requests

6 participants