Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include Brown Carbon for AOD #9

Merged
merged 3 commits into from
Mar 7, 2023
Merged

include Brown Carbon for AOD #9

merged 3 commits into from
Mar 7, 2023

Conversation

mmanyin
Copy link
Collaborator

@mmanyin mmanyin commented Mar 7, 2023 •
edited
Loading

This PR is non-zero-diff for OH.
It is intended to complete v1.1.0 .
It depends on the following other repositories:
GEOSgcm: 6866df080aa0734737ea5a7d1d4985a67bb9f363
GEOSgcm_GridComp: fbc9b5ca145fbc163eec32bd3c82e68994f38c84
GEOSchem_GridComp: 916c59b9b9a366a6094ec077a4de4f5d6187605e
GOCART: 6e237a8ed45f742a5a68695e0e8180aa096ad188
GEOSgcm_App: 839a2696dc15592bb16fba22c9f0313b4579acaf

Additions:

  • Added NOTES.wiki, instructions on how to compile & use, a duplicate of the GitHub wiki for QuickChem;
    this is to help us track how it changes over time
    Changes:
  • Changed AOD calculation to include Brown Carbon scattering coefficient
  • MERRA2-GMI output files have been relocated to /css

@mmanyin mmanyin added the Non 0-diff The changes in this pull request are non-zero-diff label Mar 7, 2023
@mmanyin mmanyin requested a review from a team as a code owner March 7, 2023 17:11
@mmanyin
Copy link
Collaborator Author

mmanyin commented Mar 7, 2023

Until this PR is approved, and QuickChem v1.1.0 is released, the process of building the code is:
Clone GEOSgcm
git checkout 6866df080aa0734737ea5a7d1d4985a67bb9f363
edit components.yaml and make the entry for QuickChem 'main' instead of v1.1.0
mepo clone
cd to QuickChem
git merge feature/mmanyin/add_brown_carbon
Then build as usual

@mmanyin mmanyin changed the title introduce Boost climatology; scale Boost output; include Brown Carbon for AOD include Brown Carbon for AOD Mar 7, 2023
sstrode
sstrode approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@sstrode sstrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are consistent with our previous discussions on adding brown carbon into the AOD calculation

@mmanyin mmanyin merged commit 93abb39 into main Mar 7, 2023
@mmanyin mmanyin deleted the feature/mmanyin/add_brown_carbon branch March 7, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrode sstrode sstrode approved these changes

Assignees

@sstrode sstrode

Labels
Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmanyin @sstrode