Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{P} Frontend enhance feedback #49

Open
2 tasks
FlorianDeconinck opened this issue Jun 11, 2024 · 4 comments
Open
2 tasks

{P} Frontend enhance feedback #49

FlorianDeconinck opened this issue Jun 11, 2024 · 4 comments

Comments

@FlorianDeconinck
Copy link
Collaborator

FlorianDeconinck commented Jun 11, 2024

The frontend of NDSL (gt4py.cartesian for stencils and DaCe parsing for orchestration) can always be enhanced when erroring out for a better user experience. This tasks collects the ongoing less than ideal or outright missing feedback.


@FlorianDeconinck FlorianDeconinck changed the title Frontend enhance feedback {P} Frontend enhance feedback Nov 7, 2024
@FlorianDeconinck
Copy link
Collaborator Author

Below we list issues encountered and their tickets if those are down

@FlorianDeconinck
Copy link
Collaborator Author

Extra argument on stencils calls can be taken for domain, extent.

E.g.

@gtscript.stencil(backend="dace:cpu")
def absolute_K_index__field__dace(
    in_field: Field[IJK, np.float64],
    index_field: Field[IJK, np.int32],
    out_field: Field[IJK, np.float64],
    index: int,
):
    with computation(PARALLEL), interval(...):
        out_field = in_field.at(K=index_field)

called with

absolute_K_index__field__dace(in_arr, idx_arr, out_arr, index, rel_index)

Will override domain with the value of index (and die)

@FlorianDeconinck
Copy link
Collaborator Author

Un-useful comment when type mismatch on BinOp (see gtc/common.py:292).

Error is "Type mismatch in .." but doesn't give the line or the source

@CharlesKrop
Copy link

Using a gt4py function outside of a stencil does not provide useful error, and in some cases does not even error (i.e. round returns None and execution continues). Need more descriptive error handling explaining that these functions cannot be used in normal python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants